Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce wasm file size and improve Gas and size benchmark compare to NEAR-SDK-RS #414

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pivanov
Copy link

@pivanov pivanov commented Oct 3, 2024

The results from this PR have been compared to commit 451d598. Note that tests added after this commit are not included in these results.

You can view the detailed results here:
Results Gist.

We're also working on automating markdown table generation for easier comparisons in the future!

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@pivanov pivanov force-pushed the feat-reduce-wasm-file-size branch 2 times, most recently from c8026d0 to e6726de Compare October 3, 2024 14:54
packages/near-sdk-js/src/cli/post-install.ts Outdated Show resolved Hide resolved
@frol
Copy link
Contributor

frol commented Oct 9, 2024

@pivanov Thank you for documenting the benchmark results! Those are quite useful

@pivanov pivanov force-pushed the feat-reduce-wasm-file-size branch from f573a8e to 0264750 Compare October 18, 2024 15:14
@dim-daskalov
Copy link

Hey @frol, any progress on this one, should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

3 participants